Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme #610

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Update readme #610

merged 6 commits into from
Feb 13, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Feb 13, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Update the readme to better reflect the current state of the SDK.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from MGibson1 February 13, 2024 10:16
@bitwarden-bot
Copy link

bitwarden-bot commented Feb 13, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 9a03ac67-1c8c-4fb3-8745-e08f37179208

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 9 When installing a package, its pin version should be defined
MEDIUM Using Platform Flag with FROM Command /Dockerfile: 4 Don't use '--platform' flag with FROM

Fixed Issues

Severity Issue Source File / Package
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 9
MEDIUM Using Platform Flag with FROM Command /Dockerfile: 4

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6882a20) 59.44% compared to head (2c2d3dd) 59.40%.
Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   59.44%   59.40%   -0.05%     
==========================================
  Files         171      171              
  Lines       10324    10345      +21     
==========================================
+ Hits         6137     6145       +8     
- Misses       4187     4200      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MGibson1
MGibson1 previously approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@MGibson1 MGibson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one note on big bold guarantees 😄

README.md Outdated Show resolved Hide resolved
@Hinton Hinton requested a review from MGibson1 February 13, 2024 20:12
@Hinton Hinton merged commit cfced90 into main Feb 13, 2024
58 checks passed
@Hinton Hinton deleted the ps/readme branch February 13, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGibson1 MGibson1 MGibson1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @bitwarden-bot @MGibson1